After using Automapper to map a ViewModel how and what should I test?
صفحه اصلي

After using Automapper to map a ViewModel how and what should I test?



I am attempting to test the Index action of a controller. The action uses AutoMapper to map a domain Customer object to a view model TestCustomerForm. While this works I am concerned about the best way to test the results that I am receiving from the Index action.

The controller's index action looks like this:

public ActionResult Index() {     TestCustomerForm cust = Mapper.Map<Customer,         TestCustomerForm>(_repository.GetCustomerByLogin(CurrentUserLoginName));      return View(cust); } 

And its TestMethod looks like this:

[TestMethod] public void IndexShouldReturnCustomerWithMachines() {     // arrange     var customer = SetupCustomerForRepository(); // gets a boiler plate customer     var testController = CreateTestController();      // act     ViewResult result = testController.Index() as ViewResult;      // assert     Assert.AreEqual(customer.MachineList.Count(),         (result.ViewData.Model as TestCustomerForm).MachineList.Count()); } 

In the CreateTestController method I use Rhino.Mocks to mock a customer repository and set it up to return the customer from SetupCustomerForRepository. In this manner I know that the repository will return the intended customer when the Index action calls _repository.GetCustomerByLogin(CurrentUserLoginName). Therefore, I figure asserting an equal count is adequate to satisfy IndexShouldReturnCustomerWithMachines.

All of that said I am concerned as to what I should be testing.

  1. It seems presumptuous to cast the result.ViewData.Model as TestCustomerForm. Is this really an issue? This concerns me because in this instance I am not truly doing test driven development and it seems like I am counting on a particular implementation to satisfy the test.
  2. Are there more appropriate tests to ensure correct mapping?
  3. Should I be testing each mapped property from the TestCustomerForm?
  4. Are there more general controller action tests that I should be doing?

JavaScript action result no longer working after converting to partial view

1:

Help! Why do my IE users get randomly logged off?
This is one of the reasons why i move AutoMapper into a custom ActionResult or an ActionFilter. asp.net mvc jquery form plugin upload(file not recieved by the controller) At any point, you only really want to test this you mapped Foo to FooDto, although not necessarily test the actual mapping. .NET MVC Masking Password textboxes By moving AutoMapper into the layer boundaries (such as between controller an view), you must merely test what you're telling AutoMapper to do.. MVC ViewData not rendering in View This is similar to testing a ViewResult. fluent Nhibernatetest mappings You don't test from a controller this a view was rendered, although rather this you told MVC to render such-and-such view. would i need antixss for report printing Our action result becomes:. using MultiSelectList in ASP.NET MVC
public class AutoMapViewResult : ActionResult {     public Type SourceType { receive ; private set; }     public Type DestinationType { receive ; private set; }     public ViewResult View { receive ; private set; }      public AutoMapViewResult(Type sourceType, Type destinationType, ViewResult view)     {         SourceType = sourceType;         DestinationType = destinationType;         View = view;     }      public override void ExecuteResult(ControllerContext context)     {         var model = Mapper.Map(View.ViewData.Model, SourceType, DestinationType);          View.ViewData.Model = model;          View.ExecuteResult(context);     } } 
With a helper method on a base controller class:.
protected AutoMapViewResult AutoMapView<TDestination>(ViewResult viewResult) {     return new AutoMapViewResult(viewResult.ViewData.Model.GetType(), typeof(TDestination), viewResult); } 
Which then makes the controller now only specify what to map to/from, instead of operating the actual mapping:.
public ActionResult Index(int minSessions = 0) {     var list = from conf in _repository.Query()                 where conf.SessionCount >= minSessions                 select conf;      return AutoMapView<EventListModel[]>(View(list)); } 
At this point, I only need to test, "make sure this you're mapping this Foo object to this destination FooDto type", without needing to actually perform the mapping.. EDIT:. Here's an case of a test snippet:.
var actionResult = controller.Index();  actionResult.ShouldBeInstanceOf<AutoMapViewResult>();  var autoMapViewResult = (AutoMapViewResult) actionResult;  autoMapViewResult.DestinationType.ShouldEqual(typeof(EventListModel[])); autoMapViewResult.View.ViewData.Model.ShouldEqual(queryResult); autoMapViewResult.View.ViewName.ShouldEqual(string.Empty); 

2:

I would probably separate the coupling between AutoMapper and the controller by introducing an abstraction:.
public interface IMapper<TSource, TDest> {     TDest Map(TSource source); }  public CustomerToTestCustomerFormMapper: IMapper<Customer, TestCustomerForm> {     static CustomerToTestCustomerFormMapper()     {         // TODO: Configure the mapping rules here     }      public TestCustomerForm Map(Customer source)     {         return Mapper.Map<Customer, TestCustomerForm>(source);     } } 
Next you pass this into the controller:.
public HomeController: Controller {     private readonly IMapper<Customer, TestCustomerForm> _customerMapper;     public HomeController(IMapper<Customer, TestCustomerForm> customerMapper)     {         _customerMapper = customerMapper;     }      public ActionResult Index()     {         TestCustomerForm cust = _customerMapper.Map(             _repository.GetCustomerByLogin(CurrentUserLoginName)         );         return View(cust);     } } 
And in your unit test you would use your favorite mocking framejob to stub this mapper..


73 out of 100 based on 13 user ratings 253 reviews

^